Michael Büchler has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44167 )
Change subject: mb/acer/m3800: add Acer Aspire M3800 desktop
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44167/2/src/mainboard/acer/m3800/Kc...
File src/mainboard/acer/m3800/Kconfig:
https://review.coreboot.org/c/coreboot/+/44167/2/src/mainboard/acer/m3800/Kc...
PS2, Line 34: _
Hrm. […]
I had tested with flashrom <1.0 and maybe I was just confused. Tested again with flashrom-1.2 and it doesn't complain for "coreboot -> vendor BIOS". Thanks!
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/ds...
File src/mainboard/acer/m3800/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/ds...
PS1, Line 10: 0x20090419 // OEM revision
Sure thing.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44167
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I846cf5f4f1ef27fc644676a4c6f7a333e061f6cf
Gerrit-Change-Number: 44167
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Büchler
michael.buechler@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maciej Matuszczyk
maccraft123mc@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 21 Sep 2020 21:56:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Büchler
michael.buechler@posteo.net
Gerrit-MessageType: comment