17 Jan
2025
17 Jan
'25
3:08 a.m.
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86013?usp=email )
Change subject: soc/mediatek/mt8196: Add mtk-fsp loader in ramstage ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/soc/mediatek/common/include/soc/memlayout.h:
https://review.coreboot.org/c/coreboot/+/86013/comment/fc28965d_181adc00?usp... : PS2, Line 16: #define FSP_INIT_CODE(addr, size) \
Done
Ah sorry. I got `DRAM_INIT_CODE` and `DRAM_DMA` mixed up when reading the code. Feel free to move this back (or not).
--
To view, visit https://review.coreboot.org/c/coreboot/+/86013?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia73d241694ca9a4686bf4b0533c51a663a765c21
Gerrit-Change-Number: 86013
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Jarried Lin jarried.lin@mediatek.com
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 11:08:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jarried Lin jarried.lin@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com