Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33196 )
Change subject: siemens/mc_apl5: Change PTN interface settings
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33196/1/src/mainboard/siemens/mc_apl1/varian...
File src/mainboard/siemens/mc_apl1/variants/mc_apl5/ptn3460.c:
https://review.coreboot.org/#/c/33196/1/src/mainboard/siemens/mc_apl1/varian...
PS1, Line 79: -
No need for the hyphen here. […]
You are right, that's the default setting.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33196
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278e761566a112d95cbd6c79e09c076d70b93e8f
Gerrit-Change-Number: 33196
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 05 Jun 2019 12:57:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment