[coreboot-gerrit] Change in coreboot[master]: lib/cbfs: Add fallback to RO region to cbfs_boot_locate

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36545 )

Change subject: lib/cbfs: Add fallback to RO region to cbfs_boot_locate
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36545/6/src/lib/cbfs.c 
File src/lib/cbfs.c:

https://review.coreboot.org/c/coreboot/+/36545/6/src/lib/cbfs.c@68 
PS6, Line 68: 		/* When VBOOT_ENABLE_CBFS_FALLBACK is enabled and a file is not available in the
> Correct long-form multi-line comment style is […]

I agree with you on the comment style. I normally use that one as well. I looked at the next bigger block (from line 136) ad adapted to that style expecting this is the method to use. Now reverted this.

I updated the comment a bit to make it less bulky. But didn't remove it completely. I assume this is fine with you.

Also updated the debug message as you indicated. Removed this BIG function name which was handy during debug but not that much now. I didn't remove it completely because I think it is important to know from the log that this feature kicked in.

https://review.coreboot.org/c/coreboot/+/36545/6/src/lib/cbfs.c@78 
PS6, Line 78: CBFS_BOOT_LOCATE:
> nit: use __func__ if you want to output the function name, but the other code here doesn't do that e […]

Done