Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42208 )
Change subject: soc/amd/picasso/bootblock: Clear BSS ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42208/1/src/soc/amd/picasso/bootblo... File src/soc/amd/picasso/bootblock/pre_c.S:
https://review.coreboot.org/c/coreboot/+/42208/1/src/soc/amd/picasso/bootblo... PS1, Line 21: /* clear .bss section since it is not cleared on S3 resume. * I'd probably skip saying "since it's not cleared on S3 resume. The next PSP bl drop will reload, and therefore rezero. However, I think it's a good measure to zero anyway, as we're currently relying on the compression util pre-zeroing the image for us.
Also, for clarity, I'd move this new block of code above line 15 so that we keep all the stack pointer manipulation as close as possible to the call bootblock_c_entry.