EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45193 )
Change subject: mb/google/octopus/variants/fleex: support LTE power sequence
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45193/2/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/fleex/variant.c:
https://review.coreboot.org/c/coreboot/+/45193/2/src/mainboard/google/octopu...
PS2, Line 9: struct gpio_with_delay {
: gpio_t gpio;
: unsigned int delay_msecs;
: };
:
: static void power_off_lte_module(u8 slp_typ)
: {
: const struct gpio_with_delay lte_power_off_gpios[] = {
: {
: GPIO_161, /* AVS_I2S1_MCLK -- PLT_RST_LTE_L */
: 30,
: },
: {
: GPIO_117, /* PCIE_WAKE1_B -- FULL_CARD_POWER_OFF */
: 100
: },
: {
: GPIO_67, /* UART2-CTS_B -- EN_PP3300_DX_LTE_SOC */
: 0
: }
: };
:
: for (int i = 0; i < ARRAY_SIZE(lte_power_off_gpios); i++) {
: gpio_output(lte_power_off_gpios[i].gpio, 0);
: mdelay(lte_power_off_gpios[i].delay_msecs);
: }
: }
The exact same power-off sequence is implemented for bobba variant. […]
okay, I'll do it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45193
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b56ef8ff346c1d4edd5aad04d4a7396c4702ffc
Gerrit-Change-Number: 45193
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Sep 2020 17:30:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment