Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41605 )
Change subject: drivers/ocp/ipmi: Add ipmi POST start/end command
......................................................................
Patch Set 4: -Code-Review
With this design, POST start/end IPMI commands are sent during ramstage, when the IPMI_OCP device is initialized and finalized.
Ideally the behavior should be similar to traditional firmware,I think:
* POST start IPMI command should be sent as early as possible, in romstage when IPMI communication is established.
* POST end IPMI command should be sent as late as possible, either in ramstage just before control is given to payload, or in Linuxboot uinit just before control is given to target OS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41605
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide0e2a52876db555ed8b5e919215e85731fd80ed
Gerrit-Change-Number: 41605
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 30 Jun 2020 17:18:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment