HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31007 )
Change subject: nb/intel/i945: Check if interleaved even if rank #4 size is zero
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31007/4/src/northbridge/intel/i945/raminit.c
File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/#/c/31007/4/src/northbridge/intel/i945/raminit.c...
PS4, Line 2556:
:
:
without this, the loop seems useless...
here if banksize[4]=0, and the "sysinfo->interleaved" is true, will keep using "bankaddr = 0" even for banksize[5,6 and 7]
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31007
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf130a3d4b6f8fa816f7a5f06822a9b8807be3d4
Gerrit-Change-Number: 31007
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 24 Mar 2019 09:53:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment