Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31635 )
Change subject: soc/intel/skylake: nhlt: Add 24-bit blobs for Max98373
......................................................................
Patch Set 5:
I will see if Caveh is having better luck on atlas, but using this patch (along with 1505199 and 1547644), I don't get audio on nocturne in that as soon as it boots into kernel, it reboots and then boots off of emmc instead of the USB stick containing this change. Since the FS on emmc doesn't have kernel or overlay patch, my guess is that's why audio doesn't work (as AP firmware still has the coreboot change in place).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31635
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62cc109fb0aca9269736779a6ce80980b0571b78
Gerrit-Change-Number: 31635
Gerrit-PatchSet: 5
Gerrit-Owner: Jenny Tc
jenny.tc@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jenny Tc
jenny.tc@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Jenny Tc
jenny.tc@intel.corp-partner.google.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Mon, 15 Apr 2019 19:40:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment