Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43612 )
Change subject: ec/system76_ec: add support for System76 EC
......................................................................
Patch Set 16:
It is very different from the other console methods in how it works that it
does not make sense to combine it with another console method, in my opinion.
Well, it's a rather mainboard specific console, in a way like `qemu_debugcon`.
They could be grouped as `board_console`, for instance. But as long as there
are only two (doesn't explode yet), it's probably not worth it yet.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43612
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f693268d94b693b6764e4a3baf4c3180689f3be
Gerrit-Change-Number: 43612
Gerrit-PatchSet: 16
Gerrit-Owner: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Jul 2020 20:09:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment