HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33783 )
Change subject: device/oprom/realmode/x86: Fix coding standard problem from // to /* */
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/33783/5/src/device/oprom/realmode/x86.c
File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/#/c/33783/5/src/device/oprom/realmode/x86.c@89
PS5, Line 89: struct eregs reg_info = {
: .eax = X86_EAX,
: .ecx = X86_ECX,
: .edx = X86_EDX,
: .ebx = X86_EBX,
: .esp = X86_ESP,
: .ebp = X86_EBP,
: .esi = X86_ESI,
: .edi = X86_EDI,
: .vector = M.x86.intno,
: .error_code = 0, /* FIXME: fill in */
: .eip = X86_EIP,
: .cs = X86_CS,
: .eflags = X86_EFLAGS
: };
are you recommending me to make it clang-format for this ?
I don't know if https://review.coreboot.org/c/coreboot/+/33405 recommend us to use clang-format or not.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I321d9e54fee42cd9f0cff5f962246934209577f7
Gerrit-Change-Number: 33783
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Sat, 29 Jun 2019 09:03:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment