Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85074?usp=email )
(
2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/fatcat: Add FW_CONFIG Support for ALC721 soundwire ......................................................................
mb/google/fatcat: Add FW_CONFIG Support for ALC721 soundwire
This change adds support for the ALC721 codec in the device tree and enables it based on the fw_config.
BUG=b:368495490 TEST=Boot on google fatcat board Change-Id: If5ca1502942f0ca009db398589c4a243d9e2804c Signed-off-by: Varun Upadhyay varun.upadhyay@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85074 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com --- M src/mainboard/google/fatcat/variants/fatcat/fw_config.c M src/mainboard/google/fatcat/variants/fatcat/overridetree.cb 2 files changed, 7 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/google/fatcat/variants/fatcat/fw_config.c b/src/mainboard/google/fatcat/variants/fatcat/fw_config.c index 3162df4..9900492 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/fw_config.c +++ b/src/mainboard/google/fatcat/variants/fatcat/fw_config.c @@ -551,7 +551,8 @@ GPIO_PADBASED_OVERRIDE(padbased_table, i2s_enable_pads); else if (fw_config_probe(FW_CONFIG(AUDIO, AUDIO_MAX98373_ALC5682_SNDW))) GPIO_PADBASED_OVERRIDE(padbased_table, sndw_external_codec_enable_pads); - else if (fw_config_probe(FW_CONFIG(AUDIO, AUDIO_ALC722_SNDW))) + else if (fw_config_probe(FW_CONFIG(AUDIO, AUDIO_ALC722_SNDW)) || + fw_config_probe(FW_CONFIG(AUDIO, AUDIO_ALC721_SNDW))) GPIO_PADBASED_OVERRIDE(padbased_table, sndw_alc722_enable_pads); else if (fw_config_probe(FW_CONFIG(AUDIO, AUDIO_ALC256_HDA))) GPIO_PADBASED_OVERRIDE(padbased_table, hda_enable_pads); diff --git a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb index bed928e..0fd79d0 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/fatcat/overridetree.cb @@ -5,6 +5,7 @@ option AUDIO_ALC722_SNDW 2 option AUDIO_ALC256_HDA 3 option AUDIO_MAX98360_ALC5682I_I2S 4 + option AUDIO_ALC721_SNDW 5 end field WIFI 4 5 option WIFI_CNVI_6 0 @@ -623,6 +624,10 @@ device generic 1.1 on probe AUDIO AUDIO_ALC722_SNDW end + # SoundWire Link 3 ID 1 + device generic 3.1 on + probe AUDIO AUDIO_ALC721_SNDW + end end end end