John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38658 )
Change subject: mb/google/drallion/variants/drallion: Update thermal configuration for DPTF
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38658/2/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/38658/2/src/mainboard/google/dralli...
PS2, Line 34: 90
Yes, for our test item request the thermal sensor trigger point is all in control.
Ack
https://review.coreboot.org/c/coreboot/+/38658/2/src/mainboard/google/dralli...
PS2, Line 60: 12
We have observed performance impact on many benchmarks due to this change. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I957d41e3c14f6dbcec8c3555382895698beabe40
Gerrit-Change-Number: 38658
Gerrit-PatchSet: 4
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 14 Feb 2020 09:29:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: John Su
john_su@compal.corp-partner.google.com
Gerrit-MessageType: comment