Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35728 )
Change subject: intel/quark: Drop xx_DEV_FUNC
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35728/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35728/1//COMMIT_MSG@8
PS1, Line 8:
Could you please add the reasoning? I assume they aren't used based on no compilation error. It would be good to capture the reasoning in the commit description.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35728
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice1062d10b793dcbeb5b2ce9e2788fd3b6b6250b
Gerrit-Change-Number: 35728
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Oct 2019 14:26:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment