Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46056 )
Change subject: acpi/device: Add GPIO binding property for an array of GPIOs ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/46056/2/src/acpi/device.c File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/46056/2/src/acpi/device.c@1035 PS2, Line 1035: nit: Probably we should add a comment here indicating what this actually generates?
Package () { name, // e.g. cs-gpios Package() { ref, index, pin, active_low, // GPIO-0 (params[0]) ref, index, pin, active_low, // GPIO-1 (params[1]) ... } }
https://review.coreboot.org/c/coreboot/+/46056/2/src/acpi/device.c@1038 PS2, Line 1038: acpi_dp_add_reference(gpio, NULL, params->ref); Do we want to support the case where params->ref is NULL and so we will have to just write a 0 for that index? Linux kernel supports the possibility of leaving holes in the array of GPIOs as well: https://www.kernel.org/doc/html/latest/firmware-guide/acpi/gpio-properties.h...