Hello Karthikeyan Ramasubramanian,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/39325
to review the following change.
Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................
mb/google/dedede: Configure EC <-> AP GPIOs
BUG=b:150869661 TEST=Build and boot the mainboard. Trigger apreset from EC console. Trigger reboot from AP console.
Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 --- M src/mainboard/google/dedede/variants/baseboard/gpio.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/39325/1
diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index cfa7d54..f71aea9 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -126,9 +126,9 @@ /* C13 : GPP_C13/UART1_TXD */ PAD_CFG_NF(GPP_C13, NONE, DEEP, NF1), /* C14 : EC_IN_RW_OD */ - PAD_CFG_NF(GPP_C14, NONE, DEEP, NF1), + PAD_CFG_GPI(GPP_C14, NONE, DEEP), /* C15 : EC_AP_MKBP_INT_L */ - PAD_CFG_NF(GPP_C15, NONE, DEEP, NF1), + PAD_CFG_GPI_APIC(GPP_C15, NONE, PLTRST, LEVEL, INVERT), /* C16 : AP_I2C_TRACKPAD_SDA_3V3 */ PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), /* C17 : AP_I2C_TRACKPAD_SCL_3V3 */ @@ -369,7 +369,7 @@ /* GPD1 : GPP_GPD1/ACPRESENT */ PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* GPD2 : EC_AP_WAKE_ODL */ - PAD_CFG_NF(GPD2, NONE, DEEP, NF1), + PAD_CFG_GPI(GPD2, NONE, DEEP), /* GPD3 : EC_AP_PWR_BTN_ODL */ PAD_CFG_NF(GPD3, NONE, DEEP, NF1), /* GPD4 : AP_SLP_S3_L */