Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56923 )
Change subject: mb/google/brya/primus: Fix G2 touchscreen reset GPIO polarity ......................................................................
mb/google/brya/primus: Fix G2 touchscreen reset GPIO polarity
modify reset_gpio as active low to meet touchscreen spec
BUG=b:195490284 BRANCH=none TEST=build coreboot and touchscreen works
Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: I7ce1b3025db8abebf5693b34da846a7e969246fb Reviewed-on: https://review.coreboot.org/c/coreboot/+/56923 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/brya/variants/primus/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/primus/overridetree.cb b/src/mainboard/google/brya/variants/primus/overridetree.cb index caca16d..938766b 100644 --- a/src/mainboard/google/brya/variants/primus/overridetree.cb +++ b/src/mainboard/google/brya/variants/primus/overridetree.cb @@ -195,7 +195,7 @@ register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)" register "generic.probed" = "1" register "generic.reset_gpio" = - "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C1)" + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)" register "generic.reset_delay_ms" = "50" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"