Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42874 )
Change subject: mb/google/kahlee: Do not enable SCI for H1_PCH_INT_ODL
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42874/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42874/4//COMMIT_MSG@7
PS4, Line 7: mb/google/kahlee: Do not enable SCI for H1_PCH_INT_ODL
A bit off-topic..
What do each of H1_ PCH_ INT_ and ODL mean in this context?
The GPIO #defines are without _ODL in soc/amd. Some boards use CR50_IRQ here?
google/cheza and google/trogdor uses name GPIO_H1_AP_INT here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42874
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec2285b76f9c5fa1b4b1be15128fea316fa04555
Gerrit-Change-Number: 42874
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jun 2020 21:26:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment