Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41723 )
Change subject: mb/google/dedede: re-arrange SPD indexes to keep all variants the same. ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41723/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41723/1//COMMIT_MSG@9 PS1, Line 9: the spd indexes of all variants will : be the same and this is updated to newest schematic already.
I don't think we need to do this. […]
Yes, that is true about variants can have their own spd index. But the CL here just follow the newest schematic of Waddledoo and Waddledee. Please check the newest schematic.
https://review.coreboot.org/c/coreboot/+/41723/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41723/1/src/mainboard/google/dedede... PS1, Line 3: empty
Why? Let's not use empty IDs. […]
Please refer to Waddledee schematic in 2020-05-20 version and this was phased in the Waddledee proto 1 build which SMT date would be soon. And we should provide FW in 5/28.
https://review.coreboot.org/c/coreboot/+/41723/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/wheelie/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41723/1/src/mainboard/google/dedede... PS1, Line 4: SPD_SOURCES += SPD_LPDDR4X_200b_8Gb_4267_DDP_1x16 #0b0001
The schematics is not reflecting this. Sorry if it has been addressed already.
Wheelie is just start to do gerber out review and committed to follow updated schematic version (0520 update here) so Wheelie would be updated as well.
- peichao is in the review list - will double check in weekly meeting.