Attention is currently required from: Paul Fagerburg.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63317 )
Change subject: util/cbmem: add type cast
......................................................................
Patch Set 3:
(1 comment)
File util/cbmem/cbmem.c:
https://review.coreboot.org/c/coreboot/+/63317/comment/cd35d033_3a9fa00b
PS3, Line 642: printf(" %llu\n", (long long)arch_convert_raw_ts_entry(stamp));
I think the cast should have been `unsigned long long`, and is unneeded, as `src/include/stdint. […]
Oh, it’s user space program, then please use the "%"PRIu64 format specifier.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87a83758b7f122b77f9631c669c7cd8df66f8d1b
Gerrit-Change-Number: 63317
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Comment-Date: Sun, 03 Apr 2022 06:31:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment