build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33052 )
Change subject: util/smctool: A tool for reading Apple SMC keys
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/33052/4/util/smctool/smctool.h
File util/smctool/smctool.h:
https://review.coreboot.org/#/c/33052/4/util/smctool/smctool.h@19
PS4, Line 19: #define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))
Prefer ARRAY_SIZE(a)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33052
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6161203e52b7f7eaa1205de06e8241d7d40a7481
Gerrit-Change-Number: 33052
Gerrit-PatchSet: 4
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 29 May 2019 13:45:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment