Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33459 )
Change subject: sb/nvidia/ck804: Prevent uninitialized reads
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33459/1/src/southbridge/nvidia/ck804/early_s...
File src/southbridge/nvidia/ck804/early_setup_car.c:
https://review.coreboot.org/#/c/33459/1/src/southbridge/nvidia/ck804/early_s...
PS1, Line 369: ck804_early_set_port(ck804_num, busn, io_base);
: ck804_early_setup(ck804_num, busn, io_base);
: ck804_early_clear_port(ck804_num, busn, io_base);
This will still blow up if ck804_num is zero.
Those use for loops to iterate over the initialized elements, so if ck804_num is zero they actually don't do anything (since there aren't any initialized elements to do anything with)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80b775370ac6485958948f0bff4510755a6cd2b8
Gerrit-Change-Number: 33459
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 21 Jun 2019 17:41:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment