Attention is currently required from: Jamie Ryu, Subrata Banik, Ethan Tsao, Ravishankar Sarawadi, John Zhao, Tim Wawrzynczak, Patrick Rudolph. Hello build bot (Jenkins), Jamie Ryu, Subrata Banik, Ethan Tsao, Ravishankar Sarawadi, John Zhao, Tim Wawrzynczak, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62013
to look at the new patch set (#5).
Change subject: soc/inte/common: override PCI dev ids and CPU ids ......................................................................
soc/inte/common: override PCI dev ids and CPU ids
Common PCI id tables and cpu id table in common driver are growing as we add new ids. As an example, lpc pci id table(lpc.c) size 238 and ADL added 100 ids. So, it'll increase size of code and increase time for detecting new platform PCI ids due to previous ids if we keep adding new ids.
Assuming we added new platform lpc ids as we do, device need to loop more than 238 time for finding the new platfrom id due to previous platform's device ids. And these previous 238 ids are not needed for new platform as 138 PCI ids are not needed for ADL. To avoid unnecessary looping and comparizon, optimizing PCI table is needed and overriding PCI id table from soc code will resolve this issue as the table only has current plaform device ids.
TEST= override tables from soc folder and build
Signed-off-by: Wonkyu Kim wonkyu.kim@intel.com Change-Id: I4c2de96389cf35381e910d44ff6e787d3a9661eb --- M src/drivers/intel/ish/ish.c M src/soc/intel/common/Kconfig.common M src/soc/intel/common/block/cpu/Kconfig M src/soc/intel/common/block/cpu/mp_init.c M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/dsp/dsp.c M src/soc/intel/common/block/dtt/dtt.c M src/soc/intel/common/block/graphics/graphics.c M src/soc/intel/common/block/hda/hda.c M src/soc/intel/common/block/i2c/i2c.c M src/soc/intel/common/block/lpc/lpc.c M src/soc/intel/common/block/p2sb/p2sb.c M src/soc/intel/common/block/pcie/pcie.c M src/soc/intel/common/block/pmc/pmc.c M src/soc/intel/common/block/sata/sata.c M src/soc/intel/common/block/smbus/smbus.c M src/soc/intel/common/block/spi/spi.c M src/soc/intel/common/block/sram/sram.c M src/soc/intel/common/block/systemagent/systemagent.c M src/soc/intel/common/block/uart/uart.c M src/soc/intel/common/block/usb4/usb4.c M src/soc/intel/common/block/xdci/xdci.c M src/soc/intel/common/block/xhci/xhci.c 23 files changed, 133 insertions(+), 40 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/62013/5