Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47724 )
Change subject: mb/google/hatch: add non-ChromeOS FMAPs
......................................................................
Patch Set 2: -Code-Review
Patch Set 2: Code-Review-1
based on some feedback in IRC, going to try and rework this so both regions can be added to the default FMAP via kconfig, and eliminate the need for these dedicated FMAPs
not a bad idea
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I296ef6ed5b46655b7d283105acdc201b6293bbd1
Gerrit-Change-Number: 47724
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 20 Nov 2020 23:15:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment