Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47207 )
Change subject: sb/intel: Don't set ACPI_EN twice
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47207/3/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/lpc.c:
https://review.coreboot.org/c/coreboot/+/47207/3/src/southbridge/intel/bd82x...
PS3, Line 48: pci_write_config8(dev, ACPI_CNTL, ACPI_EN);
Did somebody shuffle the letters of APIC here? xD
I guess 😄
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47207
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14289c9164ee1488c192fce721d86c89fa5cc736
Gerrit-Change-Number: 47207
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 05 Nov 2020 15:25:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment