[coreboot-gerrit] Change in coreboot[master]: mb/google/brya/variants/taeko: Add initial fw config for taeko

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Joey Peng, Paul Menzel, YH Lin.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57332 )

Change subject: mb/google/brya/variants/taeko: Add initial fw config for taeko
......................................................................

Patch Set 7:

(5 comments)

File src/mainboard/google/brya/variants/taeko/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/57332/comment/b7b6df3d_cb022236 
PS7, Line 1: fw_config
           : 	field KB_BL 4 4
           : 		option KB_BL_ABSENT	0
           : 		option KB_BL_PRESENT	1
           : 	end
           : 	field AUDIO 5 7
           : 		option AUDIO_UNKNOWN	0
           : 		option MAX98357_ALC5682I_I2S	1
           : 	end
           : 	field BOOT_DEVICE_EMMC 12 12
           : 		option BOOT_EMMC_DISABLED	0
           : 		option BOOT_EMMC_ENABLED	1
           : 	end
           : 	field BOOT_DEVICE_NVME 13 13
           : 		option BOOT_NVME_DISABLED	0
           : 		option BOOT_NVME_ENABLED	1
           : 	end
           : end
From config.star, I think the fw_config section should look like this:

```
fw_config
    field DB_USB 0 1
    	option DB_USB_ABSENT			0
    	option DB_USB3_NO_A			1
    end
    field DB_SD 2 3
    	option DB_SD_ABSENT			0
    	option DB_SD_OZ711LV2LN			1
    end
    field KB_BL 4
    	option KB_BL_ABSENT			0
    	option KB_BL_PRESENT			1
    end
    field AUDIO 5 7
    	option AUDIO_UNKNOWN			0
    	option AUDIO_MAX98357_ALC5682I_I2S	1
    end
    field KB_LAYOUT 8 9
    	option KB_LAYOUT_DEFAULT		0
    end
    field WIFI_SAR_ID 10 11
    	option WIFI_SAR_ID_0			0
    	option WIFI_SAR_ID_1			1
    	option WIFI_SAR_ID_2			2
    	option WIFI_SAR_ID_3			3
    end
    field BOOT_NVME_MASK 12
    	option BOOT_NVME_DISABLED		0
    	option BOOT_NVME_ENABLED		1
    end
    field BOOT_EMMC_MASK 13
    	option BOOT_EMMC_DISABLED		0
    	option BOOT_EMMC_ENABLED		1
    end
end
```

https://review.coreboot.org/c/coreboot/+/57332/comment/609a6fc4_8c7a153f 
PS7, Line 172: 			end
Looks like you'll also need a soundwire FW_CONFIG option for AUDIO

https://review.coreboot.org/c/coreboot/+/57332/comment/d3f21299_0613723a 
PS7, Line 193:  
`probe DB_SD DB_SD_PRESENT`

https://review.coreboot.org/c/coreboot/+/57332/comment/bd3cd4c0_a33ee5c0 
PS7, Line 247: chip drivers/usb/acpi
             : 						register "desc" = ""USB3 Type-C Port C1 (DB)""
             : 						register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
             : 						register "group" = "ACPI_PLD_GROUP(3, 1)"
             : 						device ref tcss_usb3_port3 on end
You need a FW_CONFIG DB_USB for this one as well (is it the same one that has the Type-A port ?)

https://review.coreboot.org/c/coreboot/+/57332/comment/ec8cde01_6b0ba16a 
PS7, Line 294:  
This would seem to depend on a probe for options that don't exist yet...

the only DB_USB options are ABSENT and NO_A, so I think you need a DB_USB option for the DB that has the Type-A port.