Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34603 )
Change subject: mb/asus: Add ASUS H110M-E/M.2 mainboard ......................................................................
Patch Set 81:
(11 comments)
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... PS76, Line 205: chip superio/nuvoton/nct5539d : device pnp 2e.2 on # UART A :
misaligned
Um, no...
https://review.coreboot.org/c/coreboot/+/34603/81/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34603/81/src/mainboard/asus/h110m-e... PS81, Line 204: device pnp 2e.ff on # passes SIO base addr to SSDT gen Indent with an extra tab
https://review.coreboot.org/c/coreboot/+/34603/81/src/mainboard/asus/h110m-e... PS81, Line 205: chip superio/nuvoton/nct5539d Two extra tabs
https://review.coreboot.org/c/coreboot/+/34603/81/src/mainboard/asus/h110m-e... PS81, Line 206: device pnp 2e.2 on # UART A Three extra tabs
https://review.coreboot.org/c/coreboot/+/34603/81/src/mainboard/asus/h110m-e... PS81, Line 244: end # superio/nuvoton/nct5539d Two tabs
https://review.coreboot.org/c/coreboot/+/34603/81/src/mainboard/asus/h110m-e... PS81, Line 245: end # SSDT gen One tab
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... File src/mainboard/asus/h110m-e_m2/include/gpio.h:
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... PS76, Line 188:
that's not intended, is it?
Done
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... PS76, Line 234: DDPB_CTRLDATA
They fit in 96 characters, maybe your gitconfig is outdated
Done
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... PS76, Line 236: DDPC_CTRLCLK
same
Done
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... PS76, Line 238: DDPC_CTRLDATA
same
Done
https://review.coreboot.org/c/coreboot/+/34603/76/src/mainboard/asus/h110m-e... PS76, Line 257: /* SUSWARN#/SUSPWRDNACK */
Isn't this the same comment as on the line below?
Done