11 comments:
File src/mainboard/asus/h110m-e_m2/devicetree.cb:
chip superio/nuvoton/nct5539d
device pnp 2e.2 on # UART A
misaligned
Um, no...
File src/mainboard/asus/h110m-e_m2/devicetree.cb:
Patch Set #81, Line 204: device pnp 2e.ff on # passes SIO base addr to SSDT gen
Indent with an extra tab
Patch Set #81, Line 205: chip superio/nuvoton/nct5539d
Two extra tabs
Patch Set #81, Line 206: device pnp 2e.2 on # UART A
Three extra tabs
Patch Set #81, Line 244: end # superio/nuvoton/nct5539d
Two tabs
Patch Set #81, Line 245: end # SSDT gen
One tab
File src/mainboard/asus/h110m-e_m2/include/gpio.h:
that's not intended, is it?
Done
Patch Set #76, Line 234: DDPB_CTRLDATA
They fit in 96 characters, maybe your gitconfig is outdated
Done
Patch Set #76, Line 236: DDPC_CTRLCLK
same
Done
Patch Set #76, Line 238: DDPC_CTRLDATA
same
Done
Patch Set #76, Line 257: /* SUSWARN#/SUSPWRDNACK */
Isn't this the same comment as on the line below?
Done
To view, visit change 34603. To unsubscribe, or for help writing mail filters, visit settings.