28 Sep
2020
28 Sep
'20
11:39 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45782 )
Change subject: drivers/intel/gma/acpi: Convert 'configure_brightness_levels.asl' to ASL+ syntax ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/45782/1/src/drivers/intel/gma/acpi/... File src/drivers/intel/gma/acpi/configure_brightness_levels.asl:
https://review.coreboot.org/c/coreboot/+/45782/1/src/drivers/intel/gma/acpi/... PS1, Line 103: 0x02 hmmmmm
https://review.coreboot.org/c/coreboot/+/45782/1/src/drivers/intel/gma/acpi/... PS1, Line 120: 0x64 This should be `100` in decimal
--
To view, visit https://review.coreboot.org/c/coreboot/+/45782
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8789ee129d1c42a36f30344655286b3c55f4f2c7
Gerrit-Change-Number: 45782
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 28 Sep 2020 09:39:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment