Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30774 )
Change subject: mb/google/hatch: Configure miscellaneous features
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/30774/5/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/30774/5/src/mainboard/google/hatch/variants/...
PS5, Line 59: # Enable S0ix
: register "s0ix_enable" = "0"
: # Enable Dynamic Platform Thermal Framework support
: register "dptf_enable" = "0"
anything is 0, u don't need to set. […]
This is place holder option whenever we will add ASL we will enable dptf_enable and when platform get stable we will enable s0ix_enable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30774
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea90a65a77ef5e45a802cfe6fd31e1921163b02b
Gerrit-Change-Number: 30774
Gerrit-PatchSet: 5
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Jan 2019 06:10:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment