Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi...
File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi...
PS5, Line 128: No GCM2 device and group2 is not visible to kernel
Then, why have an incorrect ACPI path? Shouldn't it be left as NULL or ""? I actually think adding NULL and ensuring there is a check in soc/intel/common/block/gpio which catches if acpi path returned is NULL would be helpful.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib03f6b26bafc304e531f2eaeeb0455b8333f1e44
Gerrit-Change-Number: 39344
Gerrit-PatchSet: 5
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 07 Mar 2020 01:11:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment