Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Varshit Pandya.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81188?usp=email )
Change subject: soc/amd/phoenix: make openSIL stub optional
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/phoenix/Kconfig:
https://review.coreboot.org/c/coreboot/+/81188/comment/06f762cc_988087bd :
PS1, Line 476: help
: Select this option to include the openSIL stub in the build that can
: be used for build-testing before the actual openSIL source code for a
: SoC is released.
neither the help text nor the type are needed here, but apart from that, this change will help quite […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81188?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2b48e2bbf71cd94ac7ecec13834ba36aa6c241ce
Gerrit-Change-Number: 81188
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 14 Mar 2024 17:36:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment