Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47083 )
Change subject: libpayload/keyboard: Revise keyboard_cmd() error handling ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47083/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/47083/1/payloads/libpayload/drivers... PS1, Line 183: const int ret = i8042_wait_read_ps2(); Might look better if we'd query i8042_data_ready_ps2() directly. That would also give us better control on timeouts.