Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31102 )
Change subject: soc/intel/cannonlake: Enable RTC support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31102/3/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31102/3/src/soc/intel/cannonlake/Kconfig@52 PS3, Line 52: select RTC why don't you select this here
https://github.com/coreboot/coreboot/blob/master/src/soc/intel/common/pch/Kc... ?
and get rid of icl and cnl separate CLs?