Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45012 )
Change subject: soc/intel/common: Add SMRR Lock Supported bit definition for MTRR_CAP ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45012/1/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/msr.h:
https://review.coreboot.org/c/coreboot/+/45012/1/src/soc/intel/common/block/... PS1, Line 109: (1<<11) : #define PRMRR_SUPPORTED (1<<12) : #define SMRR_LOCK_SUPPORTED (1<<14)
This file is all over the place with spaces or not 😞 but sure I'll do the right thing and add 'em h […]
So, this MSR is defined in several places (soc/intel/common & soc/intel/broadwell, as examples), and some code includes both header files that define this, so if they're defined differently, the compiler will complain... 😞 so I have to change it back or change the code that's including both... let's go with option #1 for now, and perhaps attempt a cleanup later?