Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19603 )
Change subject: soc/intel/apollolake: Bring in delta for GLK SOC
......................................................................
Patch Set 50:
(1 comment)
https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/romstage.c
File src/soc/intel/apollolake/romstage.c:
PS50, Line 347: #if !IS_ENABLED(CONFIG_SOC_INTEL_GLK) /* TODO */
Please use a C if statement unless the preprocessor if is specifically need
This field is not yet available in the GLK FSP
--
To view, visit
https://review.coreboot.org/19603
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3
Gerrit-PatchSet: 50
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Brenton Dong
brenton.m.dong@intel.com
Gerrit-Reviewer: Cole Nelson
colex.nelson@intel.com
Gerrit-Reviewer: Han Lim Ng
nhlhanlim93@gmail.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes