Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Nicholas Sudsgaard, Sean Rhodes, Stefan Reinauer.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80883?usp=email )
Change subject: payload/external/edk2: Explicitly define the build arch
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS1:
Without this option, the EDK2 UefiPayloadPkg will not build.
I'm not seeing that here on 4.22, 24.02, or main. Nor are there any build failures for jenkins.
One reason may be that it creates workspace/Build/UefiPayloadPkg$(BUILD_ARCH) (literally)
no, it doesn't. it creates:
payloads/external/edk2/workspace/Build/UefiPayloadPkgX64/RELEASE_COREBOOT/...
payloads/external/edk2/workspace/<remote repo name>/<edk2 source tree>/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80883?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icd942d0c15a99231d09f9cbdc5eb48333b6aa6e5
Gerrit-Change-Number: 80883
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Sun, 03 Mar 2024 20:56:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-MessageType: comment