Attention is currently required from: Felix Held, Martin L Roth, Michał Żygowski, Piotr Król.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79083?usp=email )
Change subject: nb/amd/pi/00730F01: introduce and use chipset devicetree ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/79083/comment/c7a3f6e8_84b85e1b : PS2, Line 16: on end # XHCI HC0 muxed with EHCI 2 : device ref sata on end : device ref ehci_0 on end # USB EHCI0 usb[0:3] is connected : device ref ehci_1 on end # USB EHCI1 usb[4:7] : device ref lpc_bridge on
i'm not sure if i understood correctly what you meant; did you mean that tab-aligning the on/off in […]
Yes, I'd prefer alignment. I'm not overzealous about it, though, and wouldn't be when formatting the code. For instance, the comment on the host bridge seems to be the only thing that's way too long. But that line looks different than the others anyway, so I would make an exception there.
Making things look more tabular, makes it easier to see exceptions, e.g. the on/off here: ``` chip southbridge/amd/pi/hudson device pci 10.0 alias xhci off end device pci 11.0 alias sata off end device pci 12.0 alias ehci_0 off end device pci 13.0 alias ehci_1 off end device pci 14.0 alias smbus on end device pci 14.2 alias hda off end device pci 14.3 alias lpc_bridge on end device pci 14.7 alias sdhci off end device pci 16.0 alias ehci_2 off end end ``` (um, looks like Gerrit uses 4-char tabs here?)
I probably wouldn't mind exceptions to the 96-char rule. I think that's a good compromise for C code that looks more ragged anyway. Tables are different.