EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39868 )
Change subject: mb/google/deltaur: Return SKU ID info ......................................................................
Patch Set 10:
(3 comments)
Or we can use as default then
const static sku_info skus[] = { /* Deltan 360 - invalid configuration */ { .id = -1, .name = "sku_invalid" }, /* Deltan */ { .id = 1, .name = "sku1" }, /* Deltan 360 signed - invalid configuration */ { .id = -1, .name = "sku_invalid" }, /* Deltan signed */ { .id = 2, .name = "sku2" }, };
https://review.coreboot.org/c/coreboot/+/39868/10/src/mainboard/google/delta... File src/mainboard/google/deltaur/sku.c:
https://review.coreboot.org/c/coreboot/+/39868/10/src/mainboard/google/delta... PS10, Line 18: uint32_t sku_id(void) maybe const
https://review.coreboot.org/c/coreboot/+/39868/10/src/mainboard/google/delta... File src/mainboard/google/deltaur/variants/deltan/include/variant/variant.h:
https://review.coreboot.org/c/coreboot/+/39868/10/src/mainboard/google/delta... PS10, Line 13: /* SKU ID structure */ move this to baseboard.
https://review.coreboot.org/c/coreboot/+/39868/10/src/mainboard/google/delta... File src/mainboard/google/deltaur/variants/deltaur/include/variant/variant.h:
https://review.coreboot.org/c/coreboot/+/39868/10/src/mainboard/google/delta... PS10, Line 12: /* SKU ID structure */ same.