Attention is currently required from: Felix Singer, Arthur Heymans, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50180 )
Change subject: arch/x86/smbios_defaults.c: Default to motherboard type ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50180/comment/5315fdbf_7b4c089a PS1, Line 9: Nearly every board that coreboot supports is a motherboard. The only board that currently overrides the function to return a different value is scaleway/tagada (SMBIOS_BOARD_TYPE_SERVER_BLADE), and is not affected by this patch.
File src/arch/x86/smbios_defaults.c:
https://review.coreboot.org/c/coreboot/+/50180/comment/63407731_3d706794 PS1, Line 63: return SMBIOS_BOARD_TYPE_MOTHERBOARD;
Why? What's the improvement?
It's to avoid having to override this for each and every motherboard (see CB:48850 for an example). I doubt this change would have any noticeable impact out of coreboot (e.g. at OS level).