Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43396 )
Change subject: soc/intel/skylake/Kconfig: Select FSPT XIP in FSP CAR is used
......................................................................
Patch Set 1:
Patch Set 1:
Why does `config FSP_T_XIP` exist? If there is no use
case to leave it disabled (I can't think of any), should
the option be removed instead?
True, this option should be removed as XIP is mandatory AFAIK
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43396
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7c984c6e2c0f93cbb97a7aa8426c2f6ef889162
Gerrit-Change-Number: 43396
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 13 Jul 2020 14:56:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment