Seunghwan Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31085 )
Change subject: mainboard/google/octopus/variants/casta: Decrease touchpad I2C CLK frequency
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31085/2/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/casta/overridetree.cb:
https://review.coreboot.org/#/c/31085/2/src/mainboard/google/octopus/variant...
PS2, Line 10: #| I2C5 | Audio |
In this CL, I don't see any I2C tuning for I2C 5 port. That is why I added that comment. […]
If we don't have to tune audio port I2C timing, then don't we specify about audio device in this structure?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31085
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7a43fe20c7e5abdf23c8c36e34c072c371563bf
Gerrit-Change-Number: 31085
Gerrit-PatchSet: 2
Gerrit-Owner: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Comment-Date: Fri, 25 Jan 2019 04:50:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-MessageType: comment
