Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32367 )
Change subject: mb/google/sarien: Fix s5 touchscreen power leakage ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/32367/4/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/#/c/32367/4/src/mainboard/google/sarien/variants... PS4, Line 23: CTXS (TS_PD)
Actually, TS_PD(GPP_E7) is RESET and leakage power was observed from RESET pin not from 3V_TSP_S0_FU […]
From the devicetree for sarien and arcada, I see only one GPIO being exported GPP_E7: https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/google/sari....
So, probably this is fine.
BTW, I just realized that you already have a power resource exported for the touchscreen device, so the kernel should already be taking care of turning off power resource in S3 and S0ix. For S5, there was a bug and I had pushed a CL for 4.4 kernel but never got a chance to upstream it. Can you try this out without any changes in ASL to see if the touchscreen power is good: crrev.com/c/1577858