Patrick Georgi (pgeorgi@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9743
-gerrit
commit 7091b749c8da14c888656aab7ed63d309808355e Author: Vadim Bendebury vbendeb@chromium.org Date: Thu Jan 8 16:36:35 2015 -0800
cbfstool: add the missing 'break'
The previous patch introduced a bug where the new added case statement was missing the break. There was no problem testing, because an unrelated parameter structure field was being modified as a result.
BRANCH=storm BUG=none TEST=compiles and runs
Change-Id: Iaeb328048f61ffd57057ebce47f2ac8e00fc5aac Signed-off-by: Patrick Georgi pgeorgi@chromium.org Original-Commit-Id: 27ecc130569e4252e4627052f617130a2017c645 Original-Change-Id: Ib3e6c4c2b5c37588c612b8ab2672f6845c1b4ecb Original-Signed-off-by: Vadim Bendebury vbendeb@chromium.org Original-Reviewed-on: https://chromium-review.googlesource.com/239598 Original-Reviewed-by: Julius Werner jwerner@chromium.org --- util/cbfstool/cbfstool.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index 3ccc786..b60f199 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -758,6 +758,7 @@ int main(int argc, char **argv) case 'D': param.copyoffset = strtoul(optarg, NULL, 0); param.copyoffset_assigned = 1; + break; case 'a': param.alignment = strtoul(optarg, NULL, 0); break;