Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38207 )
Change subject: Move "select SOC_INTEL_COMMON_BLOCK_GPIO_LEGACY_MACROS" from src/soc/intel/skylake/Kconfig to individual Skylake and Kaby Lake mainboard Kconfig's, to allow de-legacying on a per-board basis. ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38207/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38207/3//COMMIT_MSG@7 PS3, Line 7: Move Please use a shorter topic
https://review.coreboot.org/c/coreboot/+/38207/3//COMMIT_MSG@9 PS3, Line 9: legacying I'm not aware of mainboard specific gpio asl code. What needs to be done to remove that Kconfig symbol on per board basis?