3 Sep
2020
3 Sep
'20
2:47 p.m.
Taniya Das has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42095 )
Change subject: sc7180: Remove QcLib specific changes from CB UART ......................................................................
Patch Set 19:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42095/1/src/soc/qualcomm/sc7180/qup... File src/soc/qualcomm/sc7180/qupv3_config.c:
https://review.coreboot.org/c/coreboot/+/42095/1/src/soc/qualcomm/sc7180/qup... PS1, Line 57: QUPV3_UART_SRC_HZ
*ping* […]
Sure, Julius, I will upload the change.
But I remember 'QUPV3_UART_SRC_HZ' was introduced due to your earlier comments(sorry I am not able to track them back). Will remove the frequency support as well as the macro.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42095
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2531b64eddfa6e877f769af0d17be61f5e4d0c35
Gerrit-Change-Number: 42095
Gerrit-PatchSet: 19
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Roja Rani Yarubandi c_rojay@qualcomm.corp-partner.google.com
Gerrit-CC: Taniya Das tdas@codeaurora.org
Gerrit-CC: Taniya Das tdas@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 03 Sep 2020 17:47:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Roja Rani Yarubandi c_rojay@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment