Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46042 )
Change subject: vendorcode/google/chromeos: Add camera info ......................................................................
Patch Set 1:
Patch Set 1:
Hmm, it might be just me, but chrome kind of suggests the browser. In the kernel we already have some drivers like for the EC, which is called cros_ec. Perhaps we could follow the suit and use cros_eeprom? IMHO it still makes sense, because even though one could use it on another system, it was designed by and for Chrome OS.
I'm OK with something starting as cros, but I'm not that convinced on 'eeprom'. The real implementation is "cros_camera_info", a structure describing camera attributes. On MIPI it should usually live on EEPROM, but maybe we'll want to read it from some where? Especially there's no real EEPROM driver included (although maybe we should do that in future).
What about just cros_camera or cros_camera_info ?
I'm okay with either, with a slight preference for cros_camera for being shorter. :)