Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35882 )
Change subject: soc/intel: sgx: get rid of UEFI-style usage of global variable
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35882/4/src/soc/intel/apollolake/cp...
File src/soc/intel/apollolake/cpu.c:
https://review.coreboot.org/c/coreboot/+/35882/4/src/soc/intel/apollolake/cp...
PS4, Line 263: mp_run_on_all_cpus(sgx_configure, NULL);
Isn’t this here a functional change?
No, previously this check was in sgx_configure
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35882
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida6458eb46708df8fd238122aed41b57ca48c15b
Gerrit-Change-Number: 35882
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 09 Oct 2019 10:24:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment