[coreboot-gerrit] Change in ...coreboot[master]: src/security/vboot/misc.h Fix clang fail to compile

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32798 )

Change subject: src/security/vboot/misc.h Fix clang fail to compile
......................................................................

Patch Set 2:

(1 comment)

I'm surprised that GCC even compiles that, now that I think about it. I guess it must be doing the dead code elimination before type checking.

https://review.coreboot.org/#/c/32798/2/src/security/vboot/misc.h 
File src/security/vboot/misc.h:

https://review.coreboot.org/#/c/32798/2/src/security/vboot/misc.h@92 
PS2, Line 92: return
> does it work to mark dead_code_assertion_failed_at_line_##line() as __attribute__((noreturn)) in ass […]

Agreed, this should work. If not, you could also use

return dead_code_t(int);