Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42652 )
Change subject: sb/intel/i82801gx/fadt.c: Align with i82801ix
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42652/1/src/southbridge/intel/i8280...
File src/southbridge/intel/i82801gx/fadt.c:
https://review.coreboot.org/c/coreboot/+/42652/1/src/southbridge/intel/i8280...
PS1, Line 38: /* Upper word is reserved and
: Linux complains about 32 bit. */
Yes, I think
Origins of the comment: https://review.coreboot.org/1691
The code is the same, if the comment is wrong it likely applies to all three southbridges
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42652
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I930de15a6746936fa4a8f6db280b5ac60176c836
Gerrit-Change-Number: 42652
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 21 Jun 2020 17:44:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment